...
- Proposal:
- PR triggered - PR#152 - https://github.com/camaraproject/CarrierBillingCheckOut/pull/152
- Ludovic Robert also clarifies, after checking internally with business, that refund amount cannot exceed payment amount due to legal/fiscal reasons. @Ajit Raghavan shares the same view on that based on their experience.
- Discussion during the meeting:
- From 3rd April meeting:
- Refund creation
- Request model based on Payment API.
- type
- Discussion around this concept. Ludovic Robert indicates probably when the refund is total there is no need to indicate the refundAmount by the merchant. In partial refund yes, it is needed. Pedro Díez García also has doubts regarding this and will check with business. With regards to partial refund, there is the comment about how to manage the taxes.
Status title OPEN
- Discussion around this concept. Ludovic Robert indicates probably when the refund is total there is no need to indicate the refundAmount by the merchant. In partial refund yes, it is needed. Pedro Díez García also has doubts regarding this and will check with business. With regards to partial refund, there is the comment about how to manage the taxes.
- type
- List Of Refunds
- Request Model
- Regarding filter criteria:
- Ludovic Robert initiates a thread for further investment/discussion regarding the consideration of service as input for filter criteria
Status title OPEN
- Ludovic Robert initiates a thread for further investment/discussion regarding the consideration of service as input for filter criteria
- Regarding filter criteria:
- Request Model
- Request model based on Payment API.
- Refund creation
- Comments from Orange within PR (Ludovic Robert)
Most of this points are not request for change but question I got when I did this review.
- Are we sure to manage
refund_in_progress
,totally_refunded
,partially_refunded
as TransactionOperationStatus ? my point is that a payment could have been Succeeded and then refunded. Both state are valid. Need to be sure we did not need to tackle that in a specificrefundStatus
. - I'm still not sure if refund should be managed in a separate yaml or same yaml that payment. Have you @PedroDiez good rationale to make them separate?
- Are we sure that refundAmount should be mandatory ? if
type
istotal
this could be source of unnecessary error (what about a request withtype:total
and amount inconsistent btw the payment and the refund?). - If requester fill refundDetails do we need to make check vs payment item? I guess yes.
- In payment we require a
referenceCode
in the request - do we need one here for the refund?
- Are we sure to manage
- During meeting:
- TBDRefund `type` concept
- From 3rd April meeting:
- Next actions are:
AoB
- Next Meeting will be held on 2nd May
...