The following sections provide guidance on how to review a release PR / issue.
...
- Who can approve the M3 release PR ? Code Owners after RM approval is noted in the release PR or its issue.
- When to create a RM review issue ? when the release-management_maintainers list is included as a reviewer in a release PR. After creating a review issue
- When do I tick a review issue task ?
- Review actions: tick after checking the related file(s) and putting the review comment(s) in the PR/PR issue about the(se) files. Also put just OK for the file if no comments.
- Also put a comment on in the reveiw review issue istemlf about with the major review comments and the overall state of the API.
- Release actions: tick when task is done.
- When do we close the review issue ? When all 11 tasks in the review issue are ticked as done. Close as completed completed.
- Question: should we add an "M3" a milestone label so we can filter on it later ?
- How to know if an APIs is covered by RM ? Need to test Use a comment in the comment fields of the API release tracker, visible on the Meta-release page.
...
- if you see a release PR that is nearly ready, add a comment as follows: "Please add @release-management_maintainers to this PR once the PR is ready"
- for final approval use a comment: "LGTM from ReleaseManagement."
Release actions
- Tick task when checked and done.
- Check if further review by TSC / Commonalities / ICM is needed (e.g. for targeted stable APIs), and leave issue open until those reviews are marked as done and OK in the review issue
- When all tasks and complementary reviews are completed, close the review issue with a comment on the overall status of the API.
...